Site-wide disqus comments not activated via _config.yml?

[brainstorm]

Hi Michael,

Terrific job with So-simple-theme, I love it 👍

I've recently migrated my blog from WP to Jekyll and your theme, but apparently I cannot enable comments globally in _config.yml, instead I have to say comments: true on every blog post:

https://github.com/brainstorm/brainstorm.github.io/commit/3a8e9e4999f

Any ideas why?

[mmistakes]

I went with a more granular approach.

You can enable it in a few ways. Edit the post.html _layout and scripts.html _includes and remove the conditional if statement around the Disqus div and script. That will effectively turn on Disqus for every page.

Or you can modify the conditionals to now show Disqus when you add something like comments: false in a post's Front Matter YAML if there are a couple of pages you don't want comments on.

[brainstorm]

Thanks @mmistakes, I went for this option:

https://github.com/brainstorm/brainstorm.github.io/commit/cc10b7f7b3385

I think it's the one what gives most flexibility (and granularity). Would you like me to prepare a pullrequest? Are the changes acceptable for you (upstream)?

[mmistakes]

Sure looks like a good solution. Submit a PR and I'll test it out.

On Saturday, September 27, 2014, Roman Valls Guimerà <
[email protected]> wrote:

Thanks @mmistakes https://github.com/mmistakes, I went for this option:

brainstorm/brainstorm.github.io@cc10b7f
https://github.com/brainstorm/brainstorm.github.io/commit/cc10b7f7b3385

I think it's the one what gives most flexibility (and granularity). Would
you like me to prepare a pullrequest? Are the changes acceptable for you?

—
Reply to this email directly or view it on GitHub
#94 (comment)
.