Fix skin paths in README
#357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmistakes
requested changes
Nov 13, 2019
README.md
Outdated
| skin: "/assets/css/skins/default.css" | ||
| skin: "/assets/css/skins/light.css" | ||
| skin: "/assets/css/skins/dark.css" | ||
| skin: "/assets/css/skins/default.scss" |
There was a problem hiding this comment.
I think the skin paths need to stay .css since those are the paths that will be added to the head, and HTML can’t read SCSS files.
There was a problem hiding this comment.
Oops! It's my fault. Yes, the skin paths need to stay in .css, but the link to /assets/css/skins/default.css needs to be modified to /assets/css/skins/default.scss.
mmistakes
approved these changes
Nov 13, 2019
clarafy
pushed a commit
to clarafy/clarafy.github.io
that referenced
this pull request
Mar 24, 2021
Fix `skin` paths in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix.