Stop using Julia's size classes when using MMTk #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinsoon
approved these changes
Oct 6, 2023
udesou
added
the
backport-v1.9.2+RAI
mergify bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
When allocating an object, we are still allocating the number of bytes according to Julia's size classes, which may be an overestimation of the number of bytes an object actually requires. This PR removes this since this is specific to Julia's stock GC. This affects not only allocation itself but needs to be reflected in the `get_current_size` function. Needs to be merged with mmtk/julia#31. (cherry picked from commit efb9e10) # Conflicts: # mmtk/Cargo.toml
udesou
added a commit
that referenced
this pull request
Feb 28, 2024
This is an automatic backport of pull request #108 done by [Mergify](https://mergify.com). Cherry-pick of efb9e10 has failed: ``` On branch mergify/bp/v1.9.2+RAI/pr-108 Your branch is up to date with 'origin/v1.9.2+RAI'. You are currently cherry-picking commit efb9e10. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: modified: julia/mmtk_julia.c modified: mmtk/src/object_model.rs Unmerged paths: (use "git add <file>..." to mark resolution) both modified: mmtk/Cargo.toml ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> --------- Co-authored-by: Eduardo Souza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When allocating an object, we are still allocating the number of bytes according to Julia's size classes, which may be an overestimation of the number of bytes an object actually requires. This PR removes this since this is specific to Julia's stock GC. This affects not only allocation itself but needs to be reflected in the
get_current_sizefunction.Needs to be merged with mmtk/julia#31.