Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screen size agnostic grid tests #22

Conversation

eps1lon
Copy link

@eps1lon eps1lon commented Jan 13, 2021

For mui#24395 (comment)

Calling render multiple times is not supported currently.

For technical reasons as well as because it leads to generic naming of destructured methods getByTestId followed by defaultThemeGetByTestId. This particular instance is more of an argument for using screen but the argument would apply for other methods (e.g. unmount or debug).

I'll follow-up with a warning if we spot this pattern and a recommendation to use rerender. This should cover all use cases.

@mnajdova mnajdova merged commit 142c0a8 into mnajdova:feat/grid-migrate-to-emotion Jan 13, 2021
@eps1lon eps1lon deleted the feat/grid-migrate-to-emotion-test-width branch September 14, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants