Skip to content

Commit

Permalink
FIX: account for potential .{integer}_meg4 extensions in CTF format (
Browse files Browse the repository at this point in the history
…#1230)

* In copyfile_ctf change suffix .meg4 to meg4 such that files with suffix .{int}_meg4 are also renamed

* Account for potential .{int}_meg4 extensions by adding them separately to file types.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* New contributor entry to authors.rst

* Add Mara to new contributors

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Stefan Appelhoff <[email protected]>
  • Loading branch information
3 people authored Feb 29, 2024
1 parent e41b517 commit 28e8cdb
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CITATION.cff
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,10 @@ authors:
family-names: Guetschel
orcid: 'https://orcid.org/0000-0002-8933-7640'
affiliation: 'Donders Institute for Brain, Cognition and Behaviour, Radboud University, Nijmegen, Netherlands'
- given-names: Mara
family-names: Wolter
orcid: 'https://orcid.org/0000-0002-6785-9886'
affiliation: 'Centre for Integrative Neuroscience, Tübingen, Germany'
- given-names: Alexandre
family-names: Gramfort
affiliation: 'Université Paris-Saclay, Inria, CEA, Palaiseau, France'
Expand Down
1 change: 1 addition & 0 deletions doc/authors.rst
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,4 @@
.. _Jonathan Vanhoecke: https://github.com/JonathanVHoecke
.. _Ford McDonald: https://github.com/fordmcdonald
.. _Pierre Guetschel: https://github.com/PierreGtch
.. _Mara Wolter: https://github.com/marakw
3 changes: 3 additions & 0 deletions doc/whats_new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Version 0.15 (unreleased)
The following authors contributed for the first time. Thank you so much! 🤩

* `Daniel McCloy`_
* `Mara Wolter`_

The following authors had contributed before. Thank you for sticking around! 🤘

Expand Down Expand Up @@ -59,6 +60,8 @@ Detailed list of changes

- The datatype in the dataframe returned by :func:`mne_bids.stats.count_events` is now
``pandas.Int64Dtype`` instead of ``float64``, by `Eric Larson`_ (:gh:`1227`)
- The :func:`mne_bids.copyfiles.copyfile_ctf` now accounts for files with ``.{integer}_meg4`` extension, instead of only .meg4,
when renaming the files of a .ds folder, by `Mara Wolter`_ (:gh:`1230`)

⚕️ Code health
^^^^^^^^^^^^^^
Expand Down
7 changes: 7 additions & 0 deletions mne_bids/copyfiles.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,13 @@ def copyfile_ctf(src, dest):
".newds",
".res4",
)

# Consider CTF files that are split having consecutively numbered extensions
extra_ctf_file_types = tuple(
f".{i}_meg4" for i in range(1, 21)
) # cap at 20 is arbitrary
file_types += extra_ctf_file_types

# Rename files in dest with the name of the dest directory
fnames = [f for f in os.listdir(dest) if f.endswith(file_types)]
bids_folder_name = op.splitext(op.split(dest)[-1])[0]
Expand Down

0 comments on commit 28e8cdb

Please sign in to comment.