Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported Python versions: CI test matrix getting too big #933

Closed
hoechenberger opened this issue Dec 20, 2021 · 2 comments · Fixed by #934
Closed

Supported Python versions: CI test matrix getting too big #933

hoechenberger opened this issue Dec 20, 2021 · 2 comments · Fixed by #934
Assignees
Labels

Comments

@hoechenberger
Copy link
Member

hoechenberger commented Dec 20, 2021

Hello,

now that Python 3.10 is out, we'll need to add it to our CI tests.

The test matrix is already huge, any suggestions what we could do about this?

Ideas:

  • simply drop support for Python 3.7
  • run tests with mne-python:main only on the latest Python version

Thoughts?

@sappelhoff
Copy link
Member

I like your second suggestion 👍

@hoechenberger hoechenberger self-assigned this Dec 20, 2021
@larsoner
Copy link
Member

larsoner commented Dec 20, 2021

Another option is not to test every version, but just the oldest and newest (here, 3.7 and 3.10). We've skipped in-between versions in MNE-Python and never hit an issue from it at least. (The only reason we don't currently test just 3.7 and 3.10 there is for example because VTK isn't available on Windows for 3.10 yet, so the highest we can do on Windows is 3.9.) I think if you're writing a library where you have Cython or some compiled C code you probably need all of them, but given the stability and deprecation policies of the Python versions, just doing 3.7 and 3.10 is probably fine for many pure-python libraries.

hoechenberger added a commit to hoechenberger/mne-bids that referenced this issue Dec 20, 2021
sappelhoff pushed a commit that referenced this issue Dec 20, 2021
* Rework CI test matrix

Fixes #933

* Add quotation marks

* Forgot a bunch

* Fix?

* Adjust

* Whoops

* Better variable naming

* No lists in include

* Fix typo

* Ignore DeprecationWarning

* Largely reduce matrix

* Further reduce matrix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants