Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for EEGLAB: do not 'simplify cells' when loading. #1039

Merged
merged 4 commits into from
Aug 6, 2022

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Aug 4, 2022

PR Description

I think I found the problem with #991

closes #991

@cmadjar it'd be great if you could try this fix. Install it by:

pip uninstall mne_bids
pip install pip install git+https://github.com/sappelhoff/mne-bids.git@use/mne/export

if you want to go back, simply uninstall mne_bids again and re-install the version you want.

I think the problem was that we used loadmat with simplify_cells, which changes the MATLAB "structure" and leads to problems when writing back.

In the long run it'd still be nicer to switch to "mne.export" for this.

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@sappelhoff sappelhoff added this to the 0.11 milestone Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1039 (aa6e35a) into main (122f268) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
+ Coverage   95.17%   95.19%   +0.01%     
==========================================
  Files          25       25              
  Lines        3796     3805       +9     
==========================================
+ Hits         3613     3622       +9     
  Misses        183      183              
Impacted Files Coverage Δ
mne_bids/copyfiles.py 97.71% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although I'll let @cmadjar confirms it fixes the problem

Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to simplify the docstring a little

mne_bids/copyfiles.py Outdated Show resolved Hide resolved
mne_bids/copyfiles.py Outdated Show resolved Hide resolved
Co-authored-by: Richard Höchenberger <[email protected]>
@hoechenberger hoechenberger enabled auto-merge (squash) August 6, 2022 09:33
@hoechenberger hoechenberger merged commit a809234 into mne-tools:main Aug 6, 2022
@sappelhoff sappelhoff deleted the use/mne/export branch August 6, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write_raw_bids does not produce a valid SET file
3 participants