MRG: Set channel type to misc if we cannot perform a proper conversion from BIDS to MNE channel types #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
commented
Aug 19, 2022
…m BIDS to MNE channel types Previously, e.g. GSR and temperature channels could end up as "eeg" channels, for example. Fixes mne-tools#1048
hoechenberger
force-pushed
the
hoechenberger/issue1048
branch
from
2b9ea32 to
52edb4d
Compare
hoechenberger
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1052 +/- ##
=======================================
Coverage 95.19% 95.20%
=======================================
Files 25 25
Lines 3811 3815 +4
=======================================
+ Hits 3628 3632 +4
Misses 183 183
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
agramfort
approved these changes
Aug 19, 2022
This was referenced Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, e.g. GSR and temperature channels could end up as "eeg" channels, for example.
Fixes #1048
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: