Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Remove special-casing for NIRS bids-validator #1063

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Sep 1, 2022

The stable bids-validator now officially supports NIRS, so there's no need anymore for using Rob's personal branch.

cc @rob-luke

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

The stable bids-validator now officially supports NIRS,
so there's no need anymore for using Rob's personal branch.
@hoechenberger hoechenberger added bids-validator needs interaction with https://github.com/bids-standard/bids-validator tests labels Sep 1, 2022
@hoechenberger hoechenberger changed the title Remove special-casing for NIRS bids-validator MRG: Remove special-casing for NIRS bids-validator Sep 1, 2022
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #1063 (d2a5375) into main (02cd13f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1063   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files          25       25           
  Lines        3840     3840           
=======================================
  Hits         3656     3656           
  Misses        184      184           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hoechenberger hoechenberger merged commit 64f95f8 into mne-tools:main Sep 1, 2022
@hoechenberger hoechenberger deleted the bids-validator branch September 1, 2022 19:55
@rob-luke
Copy link
Member

rob-luke commented Sep 1, 2022

Thanks @hoechenberger !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bids-validator needs interaction with https://github.com/bids-standard/bids-validator tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants