-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Ensure we dont download without permission #1073
Conversation
Good enough for me! |
A few things I found and fixed along the way:
Pushing a commit now that hopefully will pass! |
... I also added dataset caching, and removed one use of |
Codecov Report
@@ Coverage Diff @@
## main #1073 +/- ##
=======================================
Coverage 94.87% 94.87%
=======================================
Files 24 24
Lines 3845 3845
=======================================
Hits 3648 3648
Misses 197 197
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
python -m pip install -e ./mne-python | ||
|
||
- name: Install MNE (main) | ||
if: "matrix.mne-version == 'mne-main'" | ||
run: | | ||
git clone --depth 1 https://github.com/mne-tools/mne-python.git -b main | ||
git clone --depth 1 --single-branch --branch main https://github.com/mne-tools/mne-python.git -b main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we keep this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's just more specific/explicit and a tiny bit faster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but we should probably remove the trailing -b main
, right? that's just a single flag specified twice?
All green, ready for review/merge from my end |
thanks a lot @larsoner 🙏 |
Thanks! |
Lots of failures locally with this.
Okay for me to put
download=False
in a bunch ofdata_path()
calls and addrequires_testing_data
calls where necessary?larsoner
branch in favor of MNE-Pythonmain
once MAINT: Ensure no datasets are downloaded in tests mne-python#11213 is merged