MRG: Fix writing preloaded data of a non-BIDS format with automated format conversion #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
force-pushed
the
hoechenberger/issue1101
branch
from
7a52ef1 to
4f0cf79
Compare
dengemann
reviewed
Nov 18, 2022
Codecov Report
@@ Coverage Diff @@
## main #1102 +/- ##
==========================================
+ Coverage 95.22% 95.24% +0.02%
==========================================
Files 24 24
Lines 3873 3873
==========================================
+ Hits 3688 3689 +1
+ Misses 185 184 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
agramfort
approved these changes
Nov 18, 2022
|
Not sure why that one CI job failed, I just restarted it. Let's see… |
|
Found the problem. Should pass now!! |
hoechenberger
changed the title
|
@agramfort @sappelhoff Feel free to merge once green, or enable automerge :) |
|
thx @hoechenberger |
|
Thanks everyone!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1101
@dengemann Can you give this a try?
PR Description
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: