-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI via catching a warning #1106
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1106 +/- ##
=======================================
Coverage 95.28% 95.28%
=======================================
Files 24 24
Lines 3900 3900
=======================================
Hits 3716 3716
Misses 184 184 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Yes that's the PR that caused it, but I think MNE-BIDS should maybe internally squash these warnings using a For example, I don't like that we have to use to fix It seems like mne-bids should just "do the right thing" with channel types and units, and the warning makes it seem to the end user like it potentially is not |
PR Description
fixes CI, see: https://github.com/mne-tools/mne-bids/actions/runs/3589485847/jobs/6041964853
I think this is because of mne-tools/mne-python#11344
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: