Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] fix links, remove ubuntu 20.04 from CI #1111

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Dec 13, 2022

PR Description

I suspect CI will also break for the Ubuntu 20.04 workflows, as it does in our scheduled workflow. We'll need to adjust it somehow, maybe by cutting it out -- it doesn't seem to be specifically needed. I'll look into it later.

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
    - [ ] whats_new.rst is updated
    - [ ] New contributors have been added to CITATION.cff
    - [ ] PR description includes phrase "closes <#issue-number>"

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not know why CIs fails

@larsoner
Copy link
Member

+1 for just cutting 20.04 out of the build matrix

@sappelhoff sappelhoff changed the title fix links [MRG] fix links, remove ubuntu 20.04 from CI Dec 13, 2022
@sappelhoff sappelhoff enabled auto-merge (squash) December 13, 2022 22:07
@sappelhoff sappelhoff merged commit 66c3ece into mne-tools:main Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #1111 (d15a96e) into main (79439c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1111   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          26       26           
  Lines        3912     3912           
=======================================
  Hits         3727     3727           
  Misses        185      185           
Impacted Files Coverage Δ
mne_bids/dig.py 98.24% <ø> (ø)
mne_bids/path.py 97.70% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sappelhoff sappelhoff deleted the fixes branch August 21, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants