Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Drop support for MNE-Python <1.3, add new CI job to cover "previous stable" MNE version #1140

Merged
merged 5 commits into from
May 29, 2023

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented May 28, 2023

PR Description

We commonly only support the latest 2 stable versions of MNE-Python. Hence I'm doing some related cleanups here.

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@hoechenberger hoechenberger marked this pull request as ready for review May 28, 2023 10:47
@hoechenberger hoechenberger changed the title Drop support for MNE-Python <1.3, add new CI job to cover "previous stable" MNE version MRG: Drop support for MNE-Python <1.3, add new CI job to cover "previous stable" MNE version May 28, 2023
@hoechenberger
Copy link
Member Author

hoechenberger commented May 28, 2023

@sappelhoff Turns out a number of tests in test_eegieeg were actually broken as they were allowed to xfail too broadly. I tried to make the tests DRY'er and fixed all the problems I found along the way.

@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Merging #1140 (f32b746) into main (a3bf0b0) will increase coverage by 2.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1140      +/-   ##
==========================================
+ Coverage   95.28%   97.59%   +2.31%     
==========================================
  Files          40       40              
  Lines        8699     8577     -122     
==========================================
+ Hits         8289     8371      +82     
+ Misses        410      206     -204     
Impacted Files Coverage Δ
mne_bids/commands/tests/test_cli.py 100.00% <100.00%> (+3.38%) ⬆️
mne_bids/tests/test_read.py 99.71% <100.00%> (+1.23%) ⬆️
mne_bids/tests/test_write.py 99.29% <100.00%> (+8.95%) ⬆️

... and 1 file with indirect coverage changes

@hoechenberger
Copy link
Member Author

Ha! Look at that coverage boost!

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

@sappelhoff sappelhoff merged commit 0193219 into mne-tools:main May 29, 2023
@hoechenberger hoechenberger deleted the min-mne-1.3 branch May 29, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants