[MRG] fix(write.py): throw warning instead of error on conflicting bids versions #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions in dataset description
…ption to check user warning
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽♂️ |
sappelhoff
approved these changes
Jul 20, 2023
|
Sorry for the delay @fordmcdonald. This looks good to me. Could you please take a look at this section in the contributor documentation: https://github.com/mne-tools/mne-bids/blob/main/CONTRIBUTING.md#instructions-for-first-time-contributors and follow the points? Thank you! |
sappelhoff
reviewed
Jul 24, 2023
sappelhoff
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
- Coverage 97.57% 97.51% -0.06%
==========================================
Files 40 40
Lines 8655 8657 +2
==========================================
- Hits 8445 8442 -3
- Misses 210 215 +5
|
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
|
thanks @fordmcdonald |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR fixes the issue where an error is thrown if the BIDSVersion defined in the dataset_description.json file does not match the MNE compliant BIDSVersion. This ensures that MNE functions in accordance with the backwards compatible nature of BIDS.
If there is a discrepancy between the versions, a user warning will be thrown and the dataset_description.json file will NOT be overwritten for preexisting keys.
Unit tests for the make_dataset_description function have been updated accordingly.
Resolves: #767 (comment)
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: