-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to delete files from a BIDS dataset #1149
Conversation
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽♂️ |
I implemented the comments @agramfort made in PR #547. @hoechenberger can take a look at the code now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We finally have the entire CRUD operation stack!
Co-authored-by: Mainak Jas <[email protected]>
Co-authored-by: Mainak Jas <[email protected]>
Co-authored-by: Mainak Jas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, but please use list comprehensions instead of map()
Co-authored-by: Richard Höchenberger <[email protected]>
Co-authored-by: Richard Höchenberger <[email protected]>
Co-authored-by: Richard Höchenberger <[email protected]>
Co-authored-by: Richard Höchenberger <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1149 +/- ##
==========================================
- Coverage 97.59% 97.51% -0.09%
==========================================
Files 40 40
Lines 8577 8654 +77
==========================================
+ Hits 8371 8439 +68
- Misses 206 215 +9
|
@hoechenberger would you be happy with the current state? |
I won't have time to review for the next few days, @sappelhoff can you take over please? |
@PierreGtch could you please solve the remaining CI failure?
Other than that, this PR looks good to me. |
@sappelhoff I actually found a very simple fix for this fixture, it should all be green now! |
the bids validator issue (ubuntu-latest, 3.11, mne-main, validator-main test suite) can be ignored, however the failures on windows seem real to me 🤔 |
I managed to solve the windows issue 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
PR Description
Add a
BIDSPath.rm
method to delete all the matching files and update thescans.tsv
andparticipants.tsv
files accordinglyC.f. #547, #443
closes #439
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: