Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test minimal vs full mne-bids install #1161

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

sappelhoff
Copy link
Member

explicitly testing a full and a minimal mne-bids install.

I think in practice this currently does not make a difference, but I think it's good to have the infrastructure here.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1161 (bbcc4fd) into main (918bb40) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1161   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files          40       40           
  Lines        8625     8625           
=======================================
  Hits         8420     8420           
  Misses        205      205           

@hoechenberger
Copy link
Member

hoechenberger commented Aug 2, 2023

Hot take:

When I install software, I expect all features to work unless I explicitly opted for some stuff not to be installed.

Instead of a [full] classifier, there should be [minimal] for those who don't care about "full" functionality (which should be the default)

I know setuptools doesn't support this and it's a pity.

@sappelhoff sappelhoff merged commit 0b06562 into mne-tools:main Aug 2, 2023
@sappelhoff sappelhoff deleted the minim branch August 2, 2023 12:56
@sappelhoff
Copy link
Member Author

I personally like to install minimal functionality and then have my pick of what I want supported and what I don't want supported, but I guess that's a matter of taste 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants