-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MEG: Add git pre-commit configuration #1173
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
- Coverage 97.63% 97.63% -0.01%
==========================================
Files 40 40
Lines 8662 8661 -1
==========================================
- Hits 8457 8456 -1
Misses 205 205
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I enabled the GitHub app so if you close this PR and open another it might show up
Cool, thanks! |
Oh the pre-commit CI bot is already here :) |
I removed yamllint and codespell for now, we can add them later |
I would say this is ready to go. In follow-up PRs we should
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! could you also add some instructions on the pre-commit hooks to the dev documentation, please?
@sappelhoff Happy? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Richard!
I copied MNE's pre-commit config
Once merged, we can enable pre-commit CI, https://pre-commit.ci
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: