Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy 2.0 deprecation #1184

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

mscheltienne
Copy link
Member

Got:

ERROR mne_icalabel/annotation/tests/test_bids.py::test_write_channels_tsv - DeprecationWarning: `in1d` is deprecated. Use `np.isin` instead.
ERROR mne_icalabel/annotation/tests/test_bids.py::test_mark_components - DeprecationWarning: `in1d` is deprecated. Use `np.isin` instead.

with the traceback:

<decorator-gen-449>:10: in write_raw_bids
    ???
/opt/hostedtoolcache/Python/3.11.6/x64/lib/python3.11/site-packages/mne_bids/write.py:1994: in write_raw_bids
    _channels_tsv(raw, channels_path.fpath, overwrite)
/opt/hostedtoolcache/Python/3.11.6/x64/lib/python3.11/site-packages/mne_bids/write.py:192: in _channels_tsv
    ch_data = _drop(ch_data, ignored_channels, "name")
/opt/hostedtoolcache/Python/3.11.6/x64/lib/python3.11/site-packages/mne_bids/tsv_handler.py:118: in _drop
    mask = np.in1d(new_data_col, values, invert=True)

when running mne-icalalbel pytest against mne_bids (main) and numpy 2.0.

@sappelhoff sappelhoff enabled auto-merge (squash) October 26, 2023 15:43
@sappelhoff
Copy link
Member

Thanks @mscheltienne, enabled auto-merge :-)

@sappelhoff sappelhoff merged commit 3a691db into mne-tools:main Oct 26, 2023
13 checks passed
@mscheltienne mscheltienne deleted the fix-numpy2.0 branch October 26, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants