Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Fix bug with writing ctc/cal for emptyroom #1189

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Nov 8, 2023

PR Description

Closes #1188

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #1189 (f6894b0) into main (b96c489) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
+ Coverage   97.62%   97.64%   +0.02%     
==========================================
  Files          40       40              
  Lines        8664     8671       +7     
==========================================
+ Hits         8458     8467       +9     
+ Misses        206      204       -2     
Files Coverage Δ
mne_bids/path.py 97.27% <100.00%> (+<0.01%) ⬆️
mne_bids/tests/test_write.py 99.50% <100.00%> (+<0.01%) ⬆️
mne_bids/utils.py 95.93% <100.00%> (+1.01%) ⬆️

@hoechenberger hoechenberger enabled auto-merge (squash) November 8, 2023 18:23
@hoechenberger hoechenberger merged commit 61b26aa into mne-tools:main Nov 8, 2023
18 checks passed
@hoechenberger
Copy link
Member

Thanks @larsoner!

@larsoner larsoner deleted the cal branch November 8, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Error when writing calibration for empty-room file
2 participants