Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate empty list as indicator for marking all channels #1307

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

drammock
Copy link
Member

PR Description

paves the way for future change in behavior of mark_channels(..., ch_names=[]) from marking all channels to marking no channels.

Closes #1294

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean and great, thanks @drammock

@sappelhoff
Copy link
Member

Most of the test failures are flukes, see:

However, these ones are real:

could you address them before we merge this, please?

@sappelhoff sappelhoff added this to the 0.16 milestone Sep 20, 2024
@sappelhoff sappelhoff added the API label Sep 20, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.46%. Comparing base (1cbcfdd) to head (a8034fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1307   +/-   ##
=======================================
  Coverage   97.45%   97.46%           
=======================================
  Files          40       40           
  Lines        8777     8781    +4     
=======================================
+ Hits         8554     8558    +4     
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drammock
Copy link
Member Author

ok @sappelhoff, looks like all CIs are happy now

@hoechenberger hoechenberger merged commit 23503f1 into mne-tools:main Sep 23, 2024
23 checks passed
@hoechenberger
Copy link
Member

Great stuff, thanks @drammock

@sappelhoff
Copy link
Member

thanks!

@drammock drammock deleted the mark-channels branch September 25, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mark_channels behavior unexpected/unintuitive
4 participants