-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate empty list as indicator for marking all channels #1307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean and great, thanks @drammock
Most of the test failures are flukes, see: However, these ones are real: could you address them before we merge this, please? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1307 +/- ##
=======================================
Coverage 97.45% 97.46%
=======================================
Files 40 40
Lines 8777 8781 +4
=======================================
+ Hits 8554 8558 +4
Misses 223 223 ☔ View full report in Codecov by Sentry. |
ok @sappelhoff, looks like all CIs are happy now |
Great stuff, thanks @drammock |
thanks! |
PR Description
paves the way for future change in behavior of
mark_channels(..., ch_names=[])
from marking all channels to marking no channels.Closes #1294
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: