-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Add overwrite to export_raw for EDF conversions #930
Conversation
Codecov Report
@@ Coverage Diff @@
## main #930 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 23 23
Lines 3488 3488
=======================================
Hits 3306 3306
Misses 182 182
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to merge when CIs are green.
Thanks Adam!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll want have a look at the tests before we merge, will get back to you shortly.
@hoechenberger merge if happy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a tiny change, good to merge once green
Thanks @adam2392! |
PR Description
Fixes: #929
Merge checklist
Maintainer, please confirm the following before merging: