Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add overwrite to export_raw for EDF conversions #930

Merged
merged 5 commits into from
Dec 18, 2021

Conversation

adam2392
Copy link
Member

PR Description

Fixes: #929

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

Merging #930 (1926845) into main (4c0755c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #930   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files          23       23           
  Lines        3488     3488           
=======================================
  Hits         3306     3306           
  Misses        182      182           
Impacted Files Coverage Δ
mne_bids/write.py 96.22% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0755c...1926845. Read the comment docs.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merge when CIs are green.

Thanks Adam!

Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll want have a look at the tests before we merge, will get back to you shortly.

@agramfort
Copy link
Member

@hoechenberger merge if happy

🙏 @adam2392

Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a tiny change, good to merge once green

@hoechenberger hoechenberger merged commit 8a29504 into mne-tools:main Dec 18, 2021
@hoechenberger
Copy link
Member

Thanks @adam2392!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When converting to EDF with _write_raw_edf, overwrite parameter should be passed
4 participants