Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Migrate report to Jinja2 #944

Merged
merged 3 commits into from
Jan 18, 2022

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Jan 18, 2022

Closes #943

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@hoechenberger hoechenberger requested review from agramfort and sappelhoff and removed request for agramfort January 18, 2022 08:54
@hoechenberger hoechenberger changed the title Migrate report to Jinja2 MRG: Migrate report to Jinja2 Jan 18, 2022
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #944 (b66a162) into main (d618c46) will decrease coverage by 0.39%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
- Coverage   94.79%   94.39%   -0.40%     
==========================================
  Files          23       25       +2     
  Lines        3495     3550      +55     
==========================================
+ Hits         3313     3351      +38     
- Misses        182      199      +17     
Impacted Files Coverage Δ
mne_bids/report/_report.py 85.71% <85.00%> (ø)
mne_bids/report/__init__.py 100.00% <100.00%> (ø)
mne_bids/report/templates/participants.jinja 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d618c46...b66a162. Read the comment docs.

@hoechenberger hoechenberger merged commit 31a870e into mne-tools:main Jan 18, 2022
@hoechenberger hoechenberger deleted the fix-doc-build branch January 18, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix report (tempita was removed upstream)
3 participants