Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump cache, install with deps #951

Merged
merged 2 commits into from
Jan 30, 2022

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff requested a review from agramfort January 30, 2022 16:47
@sappelhoff
Copy link
Member Author

probably the fix here is rather than installing mne[hdf5], to update mne-bids dependencies to optionally include pymatreader when EEGLAB operations are wanted, WDYT?

cc @hoechenberger

@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #951 (815e982) into main (31a870e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #951   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files          25       25           
  Lines        3550     3550           
=======================================
  Hits         3351     3351           
  Misses        199      199           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc4022...815e982. Read the comment docs.

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch !

@agramfort
Copy link
Member

@hoechenberger I let you merge if happy

@hoechenberger hoechenberger merged commit 92258b2 into mne-tools:main Jan 30, 2022
@hoechenberger
Copy link
Member

Thanks @sappelhoff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants