Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Add "kind" kwarg to update_anat_landmarks() #957

Merged
merged 5 commits into from
Feb 16, 2022

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Feb 16, 2022

WIP:

  • Tests
  • Changelog

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #957 (507fdc3) into main (6711c69) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
+ Coverage   94.51%   94.52%   +0.01%     
==========================================
  Files          25       25              
  Lines        3573     3583      +10     
==========================================
+ Hits         3377     3387      +10     
  Misses        196      196              
Impacted Files Coverage Δ
mne_bids/read.py 96.11% <100.00%> (ø)
mne_bids/sidecar_updates.py 98.80% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6711c69...507fdc3. Read the comment docs.

@hoechenberger hoechenberger marked this pull request as ready for review February 16, 2022 13:32
@hoechenberger hoechenberger changed the title Add "kind" kwarg to update_anat_landmarks() MRG: Add "kind" kwarg to update_anat_landmarks() Feb 16, 2022
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far so good. Tell me when I can do a final pass and merge this.

thx @hoechenberger

@agramfort agramfort merged commit e8abcad into mne-tools:main Feb 16, 2022
@agramfort
Copy link
Member

thx @hoechenberger

@hoechenberger hoechenberger deleted the update-anat-landmarks-kind branch February 16, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants