Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Report all unit test coverage #974

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Mar 3, 2022

PR Description

Codecov should combine all coverage reports (it does for MNE I think?), so this conditional should (in principle!) be unnecessary. This should be useful for #406

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@larsoner
Copy link
Member Author

larsoner commented Mar 3, 2022

Looks like the last main build had coverage of 94.53%. Hopefully this PR ends up >= that...

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #974 (a1be35d) into main (59ca433) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
+ Coverage   94.53%   94.58%   +0.05%     
==========================================
  Files          25       25              
  Lines        3584     3584              
==========================================
+ Hits         3388     3390       +2     
+ Misses        196      194       -2     
Impacted Files Coverage Δ
mne_bids/write.py 96.61% <0.00%> (+0.10%) ⬆️
mne_bids/utils.py 96.42% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59ca433...a1be35d. Read the comment docs.

@larsoner
Copy link
Member Author

larsoner commented Mar 3, 2022

Hah, +2 coverage!

@agramfort agramfort merged commit d298752 into mne-tools:main Mar 3, 2022
@agramfort
Copy link
Member

Thx @larsoner

@hoechenberger
Copy link
Member

Niiiice!!

@larsoner larsoner deleted the codecov branch March 3, 2022 17:32
@sappelhoff
Copy link
Member

I think I added that conditional at some point because I didn't want the CI to upload 10000 coverage reports :) ... but good to know that codecov deals with that internally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants