[ENH, MRG] Clarify intracranial narrative for why individual coordinates are preferred #975
Conversation
Codecov Report
@@ Coverage Diff @@
## main #975 +/- ##
==========================================
+ Coverage 94.58% 94.63% +0.05%
==========================================
Files 25 25
Lines 3584 3600 +16
==========================================
+ Hits 3390 3407 +17
+ Misses 194 193 -1
Continue to review full report at Codecov.
|
examples/convert_ieeg_to_bids.py
Outdated
| @@ -282,6 +292,7 @@ | |||
| raw = mne.io.read_raw_fif(op.join( | |||
| misc_path, 'seeg', 'sample_seeg_ieeg.fif')) | |||
| raw.info['line_freq'] = 60 # specify power line frequency as required by BIDS | |||
| raw.set_channel_types({ch: 'ecog' for ch in raw.ch_names}) # fake intracranial | |||
There was a problem hiding this comment.
It seems like it makes sense for it to be intracranial data in the raw file. This really should be checked by mne-bids that the data type matches too
There was a problem hiding this comment.
In the BIDSPath matches the raw file
There was a problem hiding this comment.
Why isn't the channel type set correctly automatically when reading the file with MNE? Is there a problem with the data? Or a bug with MNE?
|
Okay to merge? |
|
I should read that more carefully I thought it was the meg and eeg sample data, I'll fix in asap. |
|
thx @alexrockhill |
Covering the use of the Talairach transform for intracranial data without pointing out that it's quite inaccurate and citing examples MNE-Python was fixed because it's misleading to present it as just as good without comment.
Merge checklist
Maintainer, please confirm the following before merging: