Skip to content

Commit

Permalink
Fix incorrect type hint in Neuralynx I/O module (#12236)
Browse files Browse the repository at this point in the history
  • Loading branch information
hoechenberger authored and larsoner committed Nov 28, 2023
1 parent 6e93117 commit b876edb
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 3 deletions.
1 change: 1 addition & 0 deletions doc/api/reading_raw_data.rst
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ Reading raw data
read_raw_nihon
read_raw_fil
read_raw_nsx
read_raw_neuralynx

Base class:

Expand Down
9 changes: 8 additions & 1 deletion doc/changes/v1.6.rst
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
.. _changes_1_6_1:

Version 1.6.1 (unreleased)
--------------------------

- Fix bug with type hints in :func:`mne.io.read_raw_neuralynx` (:gh:`12236` by `Richard Höchenberger`_)

.. _changes_1_6_0:

Version 1.6.0 (2023-11-20)
--------------------------

Enhancements
~~~~~~~~~~~~
- Add support for Neuralynx data files with ``mne.io.read_raw_neuralynx`` (:gh:`11969` by :newcontrib:`Kristijan Armeni` and :newcontrib:`Ivan Skelin`)
- Add support for Neuralynx data files with :func:`mne.io.read_raw_neuralynx` (:gh:`11969` by :newcontrib:`Kristijan Armeni` and :newcontrib:`Ivan Skelin`)
- Improve tests for saving splits with :class:`mne.Epochs` (:gh:`11884` by `Dmitrii Altukhov`_)
- Added functionality for linking interactive figures together, such that changing one figure will affect another, see :ref:`tut-ui-events` and :mod:`mne.viz.ui_events`. Current figures implementing UI events are :func:`mne.viz.plot_topomap` and :func:`mne.viz.plot_source_estimates` (:gh:`11685` :gh:`11891` by `Marijn van Vliet`_)
- HTML anchors for :class:`mne.Report` now reflect the ``section-title`` of the report items rather than using a global incrementor ``global-N`` (:gh:`11890` by `Eric Larson`_)
Expand Down
1 change: 1 addition & 0 deletions doc/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,7 @@
"RawBrainVision",
"RawCurry",
"RawNIRX",
"RawNeuralynx",
"RawGDF",
"RawSNIRF",
"RawBOXY",
Expand Down
14 changes: 12 additions & 2 deletions mne/io/neuralynx/neuralynx.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,12 @@ def read_raw_neuralynx(
--------
mne.io.Raw : Documentation of attributes and methods of RawNeuralynx.
"""
return RawNeuralynx(fname, preload, verbose, exclude_fname_patterns)
return RawNeuralynx(
fname,
preload=preload,
exclude_fname_patterns=exclude_fname_patterns,
verbose=verbose,
)


@fill_doc
Expand All @@ -47,7 +52,12 @@ class RawNeuralynx(BaseRaw):

@verbose
def __init__(
self, fname, preload=False, verbose=None, exclude_fname_patterns: list = None
self,
fname,
*,
preload=False,
exclude_fname_patterns=None,
verbose=None,
):
_soft_import("neo", "Reading NeuralynxIO files", strict=True)
from neo.io import NeuralynxIO
Expand Down

0 comments on commit b876edb

Please sign in to comment.