Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Android Gradle Plugin 4.1.0 #47

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

moallemi
Copy link
Owner

Android Gradle Plugin 4.1.0 drops support for renaming apk. We are using a workaround to keep renaming option for gradle-advanced-build-version library.

This PR resolves #46

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #47 into master will decrease coverage by 1.67%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #47      +/-   ##
============================================
- Coverage     90.56%   88.88%   -1.68%     
- Complexity       64       65       +1     
============================================
  Files             7        7              
  Lines           159      162       +3     
  Branches         29       31       +2     
============================================
  Hits            144      144              
- Partials         15       18       +3     
Flag Coverage Δ Complexity Δ
#unittests 88.88% <71.42%> (-1.68%) 65.00 <1.00> (+1.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ion/gradleextensions/AdvancedBuildVersionConfig.kt 93.33% <50.00%> (-6.67%) 7.00 <1.00> (+1.00) ⬇️
...advancedbuildversion/AdvancedBuildVersionPlugin.kt 87.50% <66.66%> (-5.84%) 3.00 <0.00> (ø)
...advancedbuildversion/utils/CompatibilityManager.kt 91.30% <100.00%> (ø) 0.00 <0.00> (ø)
...dbuildversion/gradleextensions/FileOutputConfig.kt 88.88% <0.00%> (-3.71%) 9.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec8cf0...209c048. Read the comment docs.

@moallemi moallemi merged commit 72ff6a8 into master Oct 14, 2020
@moallemi moallemi deleted the feature/gradle.4.1.0-support branch October 14, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin stopped working on AS 4.1
1 participant