Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Version Code by Date #57

Merged
merged 1 commit into from
May 30, 2021
Merged

Conversation

moallemi
Copy link
Owner

@moallemi moallemi commented May 30, 2021

The algorithm was wrong and did not work from 2021 and later

@moallemi moallemi force-pushed the chore/remove-version-code-date branch from 1eef762 to b511e64 Compare May 30, 2021 06:29
@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #57 (c81df0d) into master (0773639) will decrease coverage by 0.60%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #57      +/-   ##
============================================
- Coverage     87.42%   86.82%   -0.61%     
+ Complexity       71       69       -2     
============================================
  Files             8        8              
  Lines           175      167       -8     
  Branches         31       31              
============================================
- Hits            153      145       -8     
  Misses            4        4              
  Partials         18       18              
Flag Coverage Δ
unittests 86.82% <ø> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...buildversion/gradleextensions/VersionCodeConfig.kt 90.32% <ø> (-1.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6fb291...c81df0d. Read the comment docs.

The algorithm was wrong and did not work from 2021 and later
@moallemi moallemi force-pushed the chore/remove-version-code-date branch from b511e64 to c81df0d Compare May 30, 2021 06:39
@moallemi moallemi merged commit 424e763 into master May 30, 2021
@moallemi moallemi deleted the chore/remove-version-code-date branch May 30, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant