Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #40, #97: Add support for year of birth #108

Merged
merged 4 commits into from
May 25, 2022
Merged

Fixes #40, #97: Add support for year of birth #108

merged 4 commits into from
May 25, 2022

Conversation

mobeigi
Copy link
Owner

@mobeigi mobeigi commented May 25, 2022

Changes:

  • Use new BirthdayCometMonthlyBirthdaysRefetchQuery GraphQL endpoint which seems identical to old BirthdayCometRootQuery endpoint but contains birthday year
  • Update ICS writer to include Birthday year in description of event
  • Handle case when birth year is hidden due to privacy (showing ???? instead)
  • Remove special case for overlap logic from Facebook BirthdayCometRootQuery offset_month logic is wrong. (No results for December) #97 as it is no longer needed with the new GraphQL endpoint
  • Update tests to support birth year

@mobeigi mobeigi merged commit 9352c43 into master May 25, 2022
@mobeigi mobeigi mentioned this pull request May 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mobeigi