Update Rust toolchain to nightly-2020-09-17 #595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice :) |
kylefleming
force-pushed
the
kyle/update-rust-toolchain
branch
from
d1f0ac4 to
f465024
Compare
|
this is defunct, we are now at 2021-03-25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR updates the Rust toolchain to
nightly-2020-09-17. This is the first version that includes the fix (rust-lang/cargo#8701) to a Cargo bug I filed earlier this year (rust-lang/cargo#8549). This bug involves Cargo's new v2 resolver, which was non-deterministically resolving features when building dependencies.We could update to the latest nightly, but in the interest of making this fix available for our project, I've elected for this minimum version instead.
In order to update to Rust
nightly-2020-09-17, I had to updatepacked_simdto version0.3.4. This was necessary because of a bug withpacked_simdand more recent versions of nightly (rust-lang/packed_simd#288). This version isn't available on crates.io, so I've pointed to the git version instead.In this PR
nightly-2020-09-17packed_simdto use the git repo instead of crates.iopacked_simdto0.3.4