Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildctl: add flag for specifying a directory that contains ca.pem, cert.pem, key.pem #1200

Closed
AkihiroSuda opened this issue Oct 11, 2019 · 4 comments · Fixed by #1284
Closed

buildctl: add flag for specifying a directory that contains ca.pem, cert.pem, key.pem #1200

AkihiroSuda opened this issue Oct 11, 2019 · 4 comments · Fixed by #1284
Labels
area/cli buildctl CLI exp/beginner kind/enhancement

Comments

@AkihiroSuda
Copy link
Member

No description provided.

@nvpandeti
Copy link

I would like to contribute to this issue. Is there any more specific specifications for this enhancement?

@AkihiroSuda
Copy link
Member Author

I'd expect buildctl --tlsdir /foo to work as an alias of buildctl --tlscacert /foo/ca.pem --tlscert /foo/cert.pem --tlskey /foo/key.pem.

Maybe the directory should default to $XDG_CONFIG_HOME/buildctl.

cc @alexellis

@nvpandeti
Copy link

If a user uses both the --tlsdir flag and one of --tlscacert --tlscert --tlskey flags, which one should override which?

@AkihiroSuda
Copy link
Member Author

error out

jeffreyhuang23 added a commit to jeffreyhuang23/buildkit that referenced this issue Dec 10, 2019
@jeffreyhuang23
Fixed issue moby#1200
5f46ed2 
Added a command-line flag (tlsdir) to buildctl that allowed for specifying a directory that contains a ca.pem, cert.pem, and key.pem. This command-line flag acts an alias of --tlscacert, --tlscert, and --tlskey. --tlsdir cannot be used at the same time as those flags, and will cause an error if done. The pkg/errors package has been added to cmd/buildctl/common/common.go to allow for the creation of this error message.

Signed-off-by: Jeffrey Huang <[email protected]>
@nvpandeti nvpandeti mentioned this issue Dec 10, 2019
Merged
jeffreyhuang23 added a commit to jeffreyhuang23/buildkit that referenced this issue Dec 12, 2019
@jeffreyhuang23
Fixed issue moby#1200
f39baa9 
Added a command-line flag (tlsdir) to buildctl that allowed for specifying a directory that contains a ca.pem, cert.pem, and key.pem. This command-line flag acts an alias of --tlscacert, --tlscert, and --tlskey. --tlsdir cannot be used at the same time as those flags, and will cause an error if done. The pkg/errors package has been added to cmd/buildctl/common/common.go to allow for the creation of this error message.

Signed-off-by: Jeffrey Huang <[email protected]>
jeffreyhuang23 added a commit to jeffreyhuang23/buildkit that referenced this issue Dec 12, 2019
@jeffreyhuang23
Fixed issue moby#1200
783a723 
Added a command-line flag (tlsdir) to buildctl that allowed for specifying a directory that contains a ca.pem, cert.pem, and key.pem. This command-line flag acts an alias of --tlscacert, --tlscert, and --tlskey. --tlsdir cannot be used at the same time as those flags, and will cause an error if done. The pkg/errors package has been added to cmd/buildctl/common/common.go to allow for the creation of this error message.

Signed-off-by: Jeffrey Huang <[email protected]>
AkihiroSuda added a commit that referenced this issue Dec 13, 2019
@AkihiroSuda
Merge pull request #1284 from jeffreyhuang23/issue-1200
1dfd864 
Fixed issue #1200 (buildctl: add --tlsdir)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cli buildctl CLI exp/beginner kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed issue #1200 (buildctl: add --tlsdir) jeffreyhuang23/buildkit
2 participants
@nvpandeti @AkihiroSuda