Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low-hanging Windows fruit #1314

Merged
merged 6 commits into from
Jan 29, 2020
Merged

Low-hanging Windows fruit #1314

merged 6 commits into from
Jan 29, 2020
+23 −9

Commits on Jan 29, 2020

  1. Support npipe the same way we support Unix sockets 

    The same function used to support Unix sockets automatically supports
Named Pipes on Windows.

This makes the default configuration option for the daemon address work
correctly on Windows.

Signed-off-by: Paul "TBBle" Hampson <[email protected]>
    @TBBle
    TBBle committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    1036faf View commit details
    Browse the repository at this point in the history

  2. Create a new Error when there is no Error to wrap 

    Wrapping a `nil` error produces `nil`, which causes the calling code to
see success, and continue on with a default-created WorkerOpt, which
causes segfaults later.

Signed-off-by: Paul "TBBle" Hampson <[email protected]>
    @TBBle
    TBBle committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    c67499d View commit details
    Browse the repository at this point in the history

  3. Recognise Runtime V2 containerd plugins 

    This makes this code successfully discover the Windows Runtime V2
(hcsshim-based) plugin now that the Windows Runtime V1 (runhcs-based)
plugin has been removed upstream.

Signed-off-by: Paul "TBBle" Hampson <[email protected]>
    @TBBle
    TBBle committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    e801cc8 View commit details
    Browse the repository at this point in the history

  4. Don't always fail euid check on Windows 

    The check for running as a non-admin euid() doesn't work on Windows,
always returning -1.

For now, treat -1 as "Probably root", and let the failures happen later.

Signed-off-by: Paul "TBBle" Hampson <[email protected]>
    @TBBle
    TBBle committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    2bee17a View commit details
    Browse the repository at this point in the history

  5. Set sensible defaults for Windows installations 

    Non-packaged execution will need this to be overridden anyway, and it
avoids a surprise "Drop state data into the current working directory"
event.

Signed-off-by: Paul "TBBle" Hampson <[email protected]>
    @TBBle
    TBBle committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    e11b881 View commit details
    Browse the repository at this point in the history

  6. Distinguish containerd failure from process exit code 

    Signed-off-by: Paul "TBBle" Hampson <[email protected]>
    @TBBle
    TBBle committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    b9cf317 View commit details
    Browse the repository at this point in the history