Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: enable previously skipped tests #4494

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

profnandaa
Copy link
Collaborator

@profnandaa profnandaa commented Dec 18, 2023

This enables 3 tests that had been previously skipped due to the lack of Windows support initially.
The remaining ones in that group, see #4485, will need some code modifications to be enabled.

--

  • cache/contenthash/checksum_test.go createRef
  • cache/manager_test.go TestSnapshotExtract
  • cache/manager_test.go TestExtractOnMutable
  • cache/manager_test.go TestMergeOp
  • cache/manager_test.go TestDiffOp
  • source/git/source_test.go testRepeatedFetch
  • source/git/source_test.go testFetchBySHA
  • source/git/source_test.go testFetchByTag
  • source/git/source_test.go testMultipleRepos
  • source/git/source_test.go TestCredentialRedaction
  • source/git/source_test.go testSubdir
  • source/http/source_test.go TestHTTPSource
  • source/http/source_test.go TestHTTPChecksum
  • source/http/source_test.go TestHTTPDefaultName

This enables 3 tests that had been previously skipped
due to the lack of Windows support initially.

The remaining ones in that group, see moby#4485, will need
some code modifications to be enabled.

Signed-off-by: Anthony Nandaa <[email protected]>
@jedevc
Copy link
Member

jedevc commented Dec 18, 2023

Assuming tests pass LGTM 🎉

@crazy-max crazy-max merged commit bbb6aac into moby:master Dec 18, 2023
60 checks passed
@profnandaa profnandaa deleted the windows/4485-enable-tests-1 branch December 18, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants