-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add buildkitd.exe to windows binaries #4662
Conversation
Signed-off-by: Ian King'ori <[email protected]>
@@ -322,8 +323,6 @@ FROM binaries AS buildkit-freebsd | |||
ENTRYPOINT ["/buildkitd"] | |||
|
|||
FROM binaries AS buildkit-windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: do we remove line 324 (FROM...
) too then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We aren't doing anything to the image for now but it is used here when TARGETOS is windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crazy-max What's the issue? We can mark it experimental in the release changelog. |
@iankingori Ideally this should work with the OCI worker as well in the release. I think atm it only works with containerd worker. With OCI worker the release tarball should contain all required extra assets (eg. linux version contains runc). We also need some documentaion that would guide users through the setup and simple usage flow, especially if setting up containerd would still be required in v0.13. |
Thanks for merging @crazy-max. @tonistiigi we are currently working on the OCI worker and shall update the docs with a windows how to guide. |
No description provided.