Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add buildkitd.exe to windows binaries #4662

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

iankingori
Copy link
Contributor

No description provided.

@@ -322,8 +323,6 @@ FROM binaries AS buildkit-freebsd
ENTRYPOINT ["/buildkitd"]

FROM binaries AS buildkit-windows
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: do we remove line 324 (FROM...) too then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't doing anything to the image for now but it is used here when TARGETOS is windows

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to release buildkitd for windows yet as this is not stable. We only produce it in the Dockerfile for testing:

# this is not in binaries-windows because it is not intended for release yet, just CI

See also #616

@tonistiigi
Copy link
Member

@crazy-max What's the issue? We can mark it experimental in the release changelog.

@crazy-max crazy-max added this to the v0.13.0 milestone Feb 20, 2024
@crazy-max crazy-max merged commit 34c8c96 into moby:master Feb 20, 2024
66 checks passed
@tonistiigi
Copy link
Member

@iankingori Ideally this should work with the OCI worker as well in the release. I think atm it only works with containerd worker. With OCI worker the release tarball should contain all required extra assets (eg. linux version contains runc). We also need some documentaion that would guide users through the setup and simple usage flow, especially if setting up containerd would still be required in v0.13.

@iankingori
Copy link
Contributor Author

Thanks for merging @crazy-max.

@tonistiigi we are currently working on the OCI worker and shall update the docs with a windows how to guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants