dockerfile: allow pivot point for --parents flag #4728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]>
This replicates similar functionality in rsync. Signed-off-by: Tonis Tiigi <[email protected]>
AkihiroSuda
reviewed
Mar 3, 2024
| As with Rsync, it is possible to limit which parent directories are preserved by | ||
| inserting a dot and a slash (`./`) into the source path. If such point exists, only parent | ||
| directories after it will be preserved. This may be especially useful copies between stages | ||
| with `--from` where the source paths need to be absolute. |
There was a problem hiding this comment.
Dockerfile version should be mentioned
AkihiroSuda
reviewed
Mar 3, 2024
AkihiroSuda
reviewed
Mar 3, 2024
| parent, pattern, ok := strings.Cut(src, "/./") | ||
| if !ok { | ||
| pattern = src | ||
| src = "/" |
There was a problem hiding this comment.
os.PathSeparator should be used ?
There was a problem hiding this comment.
No, it should always be slash. Windows works with slashes as well. If the input is not / ( and windows) then it is converted to / in NormalizePath().
|
That was fast. You rock! Thank you! 🙏🏻 |
crazy-max
approved these changes
Mar 4, 2024
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
parents-relative-dot
branch
from
2c9aba0 to
d1446a4
Compare
AkihiroSuda
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up for #3001
Similarily to
rsync--relativeflag add support for/./pivot point to mark which parent directories as kept.This is especially useful in multi-stage builds because
--frompaths need to be always full paths.cc @DYefimov