-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add details for setting up CNI for windows #4978
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a96a767
to
2449e18
Compare
2449e18
to
cdf10bb
Compare
tonistiigi
approved these changes
May 31, 2024
iankingori
approved these changes
May 31, 2024
@profnandaa You need to push again as we had a breakage in master #4979 |
cdf10bb
to
33b7660
Compare
Sure, rebased and pushed. |
33b7660
to
d8f08e7
Compare
Adds details on how to quickly set up CNI / networking for Windows, and hooking it with `buildkitd` using the `--containerd-cni-config-path` and `--containerd-cni-binary-dir` flags. Also adds a note on running `buildkitd` as a Windows Service. fixes moby#4960 Signed-off-by: Anthony Nandaa <[email protected]> Co-authored-by: Gabriel Adrian Samfira <[email protected]>
d8f08e7
to
97b80f2
Compare
gabriel-samfira
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds details on how to quickly set up CNI / networking for Windows, and hooking it with
buildkitd
using the--containerd-cni-config-path
and--containerd-cni-binary-dir
flags.Also adds a note on running
buildkitd
as a Windows Service.fixes #4960