Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: frontend/dockerfile: update integration tests for windows/wcow #5382

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielGithinji
Copy link

@danielGithinji danielGithinji commented Oct 2, 2024

Updated tests in frontend/dockerfile/dockerfile_test.go to run on Windows.
Partially addressing #4485

  • testCopyThroughSymlinkContext
  • testIgnoreEntrypoint
  • testQuotedMetaArgs
  • testDockerfileCheckHostname
  • testEmptyStages
  • testNamedImageContextScratch
  • testNamedImageContextPlatform

Copy link
Collaborator

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than those comments, the rest LGTM.

May be just update your commit message too to match the PR, with the subject:
tests: frontend/dockerfile: update integration tests for windows/wcow

frontend/dockerfile/dockerfile_test.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile_test.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile_test.go Show resolved Hide resolved
frontend/dockerfile/dockerfile_test.go Outdated Show resolved Hide resolved
@danielGithinji danielGithinji force-pushed the integration-tests branch 6 times, most recently from 7a25fb0 to ccdd43b Compare October 15, 2024 07:20
@danielGithinji danielGithinji marked this pull request as ready for review November 5, 2024 06:20
Copy link

@billywr billywr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Collaborator

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While fixing the CI, can address the extra comment.

frontend/dockerfile/dockerfile_test.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile_test.go Show resolved Hide resolved
@danielGithinji danielGithinji force-pushed the integration-tests branch 2 times, most recently from 21872b8 to 340eceb Compare November 19, 2024 08:48
frontend/dockerfile/dockerfile_test.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile_test.go Outdated Show resolved Hide resolved
@danielGithinji danielGithinji force-pushed the integration-tests branch 2 times, most recently from 6048b78 to f94db8d Compare November 22, 2024 17:57
- [x] `testCopyThroughSymlinkContext`
- [x] `testIgnoreEntrypoint`
- [x] `testQuotedMetaArgs`
- [x] `testDockerfileCheckHostname`
- [x] `testEmptyStages`
- [x] `testNamedImageContextScratch`
- [x] `testNamedImageContextPlatform`

Signed-off-by: Daniel Githinji <[email protected]>
@profnandaa
Copy link
Collaborator

/cc. @tonistiigi PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants