worker/containerd: NewWorkerOpt: remove workaround for named pipes #5399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workaround was added in 414edfa, pending changes in containerd. Those changes were included in containerd 1.7.12, which was vendored in bce2f79, so the workaround should no longer be needed. I also reformatted the code, as there's no longer a need to wrap this function since the list of arguments has been reduced. Signed-off-by: Sebastiaan van Stijn <[email protected]>
profnandaa
approved these changes
Oct 8, 2024
| address := workerOpts.Address | ||
|
|
||
| if goRuntime.GOOS == "windows" { | ||
| // TODO(profnandaa): once the upstream PR[1] is merged and |
There was a problem hiding this comment.
thanks for helping with this TODO!
There was a problem hiding this comment.
YW! I stumbled on it while working on some things in moby/moby, and it was low-hanging fruit 🥹😅
crazy-max
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to;
This workaround was added in 414edfa, pending changes in containerd. Those changes were included in containerd 1.7.12, which was vendored in bce2f79, so the workaround should no longer be needed.
I also reformatted the code, as there's no longer a need to wrap this function since the list of arguments has been reduced.