tests: add testDockerfileFromHTTP for WCOW
#5523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/dockerfile
area/llb
area/testing
area/client
area/frontend
labels
profnandaa
force-pushed
the
tests-4485-revisit-frontend
branch
from
e12bd8d
to
ef753c4
Compare
|
Will fix the failing unit tests. |
Enables `testDockerfileFromHTTP` integration test
for Windows.
Also fixes a bug where paths were being joined wrongly,
for example:
```go
path.Join("/", "\\context") // would be "/\\context"
```
Addressing tests marked as Revisit for moby#4485
Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa
force-pushed
the
tests-4485-revisit-frontend
branch
from
ef753c4
to
ca6e771
Compare
|
@tonistiigi -- fixed CI, ptal. |
tonistiigi
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables
testDockerfileFromHTTPintegration testfor Windows.
Also fixes a bug where paths were being joined wrongly, for example:
Addressing tests marked as Revisit for #4485