Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard coded syscall.AF_INET breaks ipv6 operation for ipvs destination list #2289

Closed
uablrek opened this issue Nov 1, 2018 · 3 comments
Closed

Hard coded syscall.AF_INET breaks ipv6 operation for ipvs destination list #2289

uablrek opened this issue Nov 1, 2018 · 3 comments

Comments

@uablrek
Copy link

uablrek commented Nov 1, 2018

The hard-coded value is here;
https://github.com/docker/libnetwork/blob/d7b61745d16675c9f548b19f06fda80d422a74f0/ipvs/netlink.go#L425

This breaks the ipvs sync function in Kubernetes in ipv6-only configuration with proxy-mode=ipvs as described in this issue;
kubernetes/kubernetes#65006
@uablrek uablrek mentioned this issue Dec 7, 2018
Closed
@LexCC LexCC mentioned this issue May 25, 2019
Closed
@uablrek uablrek mentioned this issue Aug 2, 2019
Closed
@aojea
Copy link

aojea commented Aug 19, 2019

@uablrek seems this was fixed by #2416

@thaJeztah
Copy link
Member

ping @selansen @euanh looks like this can be closed

thaJeztah added a commit to thaJeztah/docker that referenced this issue Sep 3, 2019
@thaJeztah
bump lib network to 92d1fbe1eb0883cf11d283cea8e658275146411d
bab58c1 
full diff: moby/libnetwork@09cdcc8...92d1fbe

relevant changes included (omitting some changes that were added _and_ reverted in this bump):

- moby/libnetwork#2433 Fix parseIP error when parseIP before get AddressFamily
  - fixes moby/libnetwork#2431 parseIP Error ip=[172 17 0 2 0 0 0 0 0 0 0 0 0 0 0 0]
  - moby/libnetwork#2289
  - this was a regression introduced in moby/libnetwork#2416 Fix hardcoded AF_INET for IPv6 address handling
- moby/libnetwork#2440 Bump hashicorp go-sockaddr v1.0.2, go-multierror v1.0.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah mentioned this issue Sep 3, 2019
Merged
@thaJeztah thaJeztah mentioned this issue Sep 3, 2019
Merged
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this issue Sep 3, 2019
@thaJeztah
bump lib network to 92d1fbe1eb0883cf11d283cea8e658275146411d
86a524a 
full diff: moby/libnetwork@09cdcc8...92d1fbe

relevant changes included (omitting some changes that were added _and_ reverted in this bump):

- moby/libnetwork#2433 Fix parseIP error when parseIP before get AddressFamily
  - fixes moby/libnetwork#2431 parseIP Error ip=[172 17 0 2 0 0 0 0 0 0 0 0 0 0 0 0]
  - moby/libnetwork#2289
  - this was a regression introduced in moby/libnetwork#2416 Fix hardcoded AF_INET for IPv6 address handling
- moby/libnetwork#2440 Bump hashicorp go-sockaddr v1.0.2, go-multierror v1.0.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Upstream-commit: bab58c19246bfaad9bbff8dd88f1b6a224b8dc22
Component: engine
thaJeztah added a commit to thaJeztah/docker that referenced this issue Sep 16, 2019
@thaJeztah
bump lib network to 92d1fbe1eb0883cf11d283cea8e658275146411d
44ca36c 
full diff: moby/libnetwork@09cdcc8...92d1fbe

relevant changes included (omitting some changes that were added _and_ reverted in this bump):

- moby/libnetwork#2433 Fix parseIP error when parseIP before get AddressFamily
  - fixes moby/libnetwork#2431 parseIP Error ip=[172 17 0 2 0 0 0 0 0 0 0 0 0 0 0 0]
  - moby/libnetwork#2289
  - this was a regression introduced in moby/libnetwork#2416 Fix hardcoded AF_INET for IPv6 address handling
- moby/libnetwork#2440 Bump hashicorp go-sockaddr v1.0.2, go-multierror v1.0.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit bab58c1)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this issue Sep 17, 2019
@thaJeztah
bump lib network to 92d1fbe1eb0883cf11d283cea8e658275146411d
4a5ccdb 
full diff: moby/libnetwork@09cdcc8...92d1fbe

relevant changes included (omitting some changes that were added _and_ reverted in this bump):

- moby/libnetwork#2433 Fix parseIP error when parseIP before get AddressFamily
  - fixes moby/libnetwork#2431 parseIP Error ip=[172 17 0 2 0 0 0 0 0 0 0 0 0 0 0 0]
  - moby/libnetwork#2289
  - this was a regression introduced in moby/libnetwork#2416 Fix hardcoded AF_INET for IPv6 address handling
- moby/libnetwork#2440 Bump hashicorp go-sockaddr v1.0.2, go-multierror v1.0.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit bab58c19246bfaad9bbff8dd88f1b6a224b8dc22)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Upstream-commit: 44ca36c7cff269fbf53b98c73b1eea36a17bdf3a
Component: engine
burnMyDread pushed a commit to burnMyDread/moby that referenced this issue Oct 21, 2019
@thaJeztah @burnMyDread
bump lib network to 92d1fbe1eb0883cf11d283cea8e658275146411d
a6903bc 
full diff: moby/libnetwork@09cdcc8...92d1fbe

relevant changes included (omitting some changes that were added _and_ reverted in this bump):

- moby/libnetwork#2433 Fix parseIP error when parseIP before get AddressFamily
  - fixes moby/libnetwork#2431 parseIP Error ip=[172 17 0 2 0 0 0 0 0 0 0 0 0 0 0 0]
  - moby/libnetwork#2289
  - this was a regression introduced in moby/libnetwork#2416 Fix hardcoded AF_INET for IPv6 address handling
- moby/libnetwork#2440 Bump hashicorp go-sockaddr v1.0.2, go-multierror v1.0.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: zach <[email protected]>
@uablrek
Copy link
Author

uablrek commented Aug 30, 2020

Problem solved a long time ago.

@uablrek uablrek closed this as completed Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix hard coded breaks ipv6 LexCC/libnetwork
3 participants
@thaJeztah @aojea @uablrek