Update runc/libcontainer to v0.0.6 #18612
Conversation
Signed-off-by: Mrunal Patel <[email protected]>
|
Does this also fix issues in this repository? (Just checking) |
|
Ah, this fixes #16681 |
|
@LK4D4 @crosbymichael PTAL |
| @@ -94,5 +97,10 @@ func New() *configs.Config { | |||
| container.AppArmorProfile = "docker-default" | |||
| } | |||
|
|
|||
| if SystemdCgroups { | |||
| container.Cgroups.Parent = "system.slice" | |||
There was a problem hiding this comment.
Now that system.slice is defined as the default systemd parent, it should be used in Apply (L166) and getSubsystemPath (L408) instead of defining default slice values there.
There was a problem hiding this comment.
runc could be used with systemd cgroups support (once proper support is added) without docker integration so we could handle that separately.
|
I reviewed the "cgroup-parent on systemd" part of the change. Can you point out which integration test is responsible for testing this option on systemd? |
|
@anusha-ragunathan AFAIK, the integration tests don't start the daemon with systemd cgroups enabled. Is that something we want to add? @LK4D4 ping |
|
Could someone restart the windows/experimental builds. I suspect that the failures are unrelated to this change. |
|
@mrunalp done. we're investigating some flaky tests though, so it's possible they fail again |
|
@thaJeztah Thanks! |
|
LGTM if jenkins is happy |
|
@mrunalp : IMO, integration tests that set native.cgroupdriver to systemd should be added, if they dont exist already. It would fill a big test gap. |
|
@anusha-ragunathan tests are running in a docker container, where there is no systemd. |
|
Experimental tests failed with I don't think this is related to this change. Is this a known issue with flakiness? @thaJeztah ? |
|
@LK4D4 @anusha-ragunathan Yep, that is the big hurdle. While it is possible to run systemd in a container, it would require quite some work to make it work for docker testing. Something we can target long term for sure but not a quick solution. |
|
This is all green now! :) |
|
Okay, at least nothing failed. |
Update runc/libcontainer to v0.0.6
This fixes the cgroup-parent for systemd cgroup implementation (opencontainers/runc#336)
For other changes, see https://github.com/opencontainers/runc/releases/tag/v0.0.6
Signed-off-by: Mrunal Patel [email protected]