Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display all backers/sponsors on site #4271

Closed
boneskull opened this issue May 7, 2020 · 0 comments
Closed

display all backers/sponsors on site #4271

boneskull opened this issue May 7, 2020 · 0 comments
Labels
area: website involving mochajs.org, but not necessarily involving docs core-team issues which must be handled by Mocha's core team

Comments

@boneskull
Copy link
Contributor

Currently we're limited to ~15 of each. Another drawback is the URL behind the logo is not visible in the browser.

I frequently get complaints/queries about why a logo is not showing. If we show all of them, then I won't.

I have a proof-of-concept which uses 11ty's data layer to pull the sponsorship information from OC's GraphQL API (the code is based on webpack's grabber).

Since this information won't be live--it will only fetch upon site build--we will need to build the site on a schedule to update the list.

The current status here is that I'm having trouble determining the difference between a "backer" and a "sponsor" (our two donation tiers) in the data coming out of OC's API. I've asked about this in their support channel. Worst-case is that the data would need manual cleaning.

So, that's what's holding up moving forward here at the moment.

(There's also some open questions, I think, around the tier structure, but that's a separate issue)
@boneskull boneskull added core-team issues which must be handled by Mocha's core team area: website involving mochajs.org, but not necessarily involving docs labels May 7, 2020
boneskull added a commit that referenced this issue May 7, 2020
@boneskull
[DO NOT MERGE] fetch sponsors at build time; closes #4271
8e0ecec
@boneskull boneskull mentioned this issue May 7, 2020
Merged
@Munter Munter closed this as completed in 12b130b May 22, 2020
craigtaub pushed a commit that referenced this issue May 22, 2020
@boneskull @Munter @craigtaub
fetch sponsors at build time, show ALL non-skeevy sponsors; closes #4271
c967789 
 (#4272)

* Show all sponsors on site

- change ordering: sponsors, then backers
- blacklist bad actors
- rename `default.html` to `default.liquid`, because it's a Liquid template.
- fiddles with the CSS a bit
- do not attempt to display a link if there is no website

* use smaller imgs for backers

* Fetch all open collective sponsor images to save their dimensions

* Reworked avatars. LEss reflows due to image dimensions. Smoother loading animation that doesn't wait for all images. Progressive enhanced

* Add standardised lazy loading to all images

* Set height on badges to avoid page reflows

* Add node version specification in .nvmrc to get netlify up to date

* Move avatars javascript to external file for better development experience

Co-authored-by: Peter Müller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: website involving mochajs.org, but not necessarily involving docs core-team issues which must be handled by Mocha's core team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boneskull