Support for environment with global and window
#1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node-webkit has a global `global` object, while the global `this` is the `window` object. Overwriting `global` with `window` breaks a lot of things.
|
Unfortunately I couldn't find a way of adding a test for this change. In fact, no-matter what I did to |
|
There is more information regarding the reason for this change at intelligentgolf/karma-nodewebkit-launcher#15 |
|
👍 |
|
Looks good to me, @markelog do you foresee this breaking anything? |
|
+1 here. This is a barrier to using Mocha to test node-webkit apps. |
jbnicolai
pushed a commit
that referenced
this pull request
Jul 14, 2014
Support for environment with `global` and `window`
Sorry for not responding right away, i'm on vacation this week |
|
No problem, was only interested in your opinion. Did some extra testing myself and concluded it was good to go. 😄 |
nknapp
added a commit
to handlebars-lang/handlebars.js
that referenced
this pull request
Sep 3, 2018
- grunt -> 1 - grunt-contrib-watch -> 1 - mocha -> 5 - in common.js: define "global" , see mochajs/mocha#1159 - in builtins.js: revert "console.log" to old value just after using the mock (in log-helper tests), because mocha calls "console.log" on failure, before "afterEach"
nknapp
added a commit
to handlebars-lang/handlebars.js
that referenced
this pull request
Sep 4, 2018
- grunt -> 1 - grunt-contrib-watch -> 1 - mocha -> 5 - in common.js: define "global" , see mochajs/mocha#1159 - in builtins.js: revert "console.log" to old value just after using the mock (in log-helper tests), because mocha calls "console.log" on failure, before "afterEach"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node-webkit has a global
globalobject, while the globalthisis thewindowobject. Overwritingglobalwithwindowbreaks a lot ofthings.