Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3822 #3823

Closed
wants to merge 1 commit into from
Closed

Fix #3822 #3823

wants to merge 1 commit into from

Conversation

cspotcode
Copy link
Contributor

@cspotcode cspotcode commented Mar 11, 2019 •
edited by plroebuck
Loading

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

Alternate Designs

Why should this be in core?

Benefits

Possible Drawbacks

Applicable issues

Fixes #3822

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 91.664% when pulling e270e9b on cspotcode:patch-2 into ca9eba6 on mochajs:master.

plroebuck
plroebuck suggested changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@plroebuck plroebuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhh, no. See reasoning in your original issue. Discuss there.

@plroebuck plroebuck mentioned this pull request Mar 12, 2019
Merged
@cspotcode cspotcode mentioned this pull request Apr 1, 2019
Closed
@boneskull
Copy link
Contributor

thanks @cspotcode, but I'm going to close this, as it exchanges one problem for another (and would need tests).

@boneskull boneskull closed this Apr 2, 2019
@cspotcode cspotcode mentioned this pull request Apr 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plroebuck plroebuck plroebuck requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--config does not resolve paths relative to CWD
4 participants
@cspotcode @coveralls @boneskull @plroebuck