Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cwd-relative pathname to load config file #3829

Merged
merged 18 commits into from
Apr 7, 2019
Merged

Use cwd-relative pathname to load config file #3829

merged 18 commits into from
Apr 7, 2019

Commits on Mar 12, 2019

  1. fix(lib/cli/config.js): Add cwd-relative fallback to load config file 

    Original code only used module-relative path loading, which made `--config` argument non-obvious.
Added fallback processing. Added debug logging. Minor cleanup.

#3822
    @plroebuck
    plroebuck committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    7d7154e View commit details
    Browse the repository at this point in the history

  2. test(integration/config.spec.js): Add test for loading from cwd-based… 

    … relative path
    @plroebuck
    plroebuck committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    49c55cc View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. Merge branch 'master' into plroebuck/config-relpath

    @plroebuck
    plroebuck authored Mar 14, 2019
    Configuration menu
    Copy the full SHA
    bcbcb6d View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2019

  1. feat(cli/config.js): Change config file load scheme to be cwd-relative 

    Changed parser load order to attempt local file load first. Additionally, made change that allows
for Mocha config to be loaded from a package.

BREAKING CHANGE: Anyone depending on previous module-based loading style will need to change to
cwd-relative scheme.
    @plroebuck
    plroebuck committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    cf62435 View commit details
    Browse the repository at this point in the history

  2. build(package.json): Add "validate-npm-package-name" package

    @plroebuck
    plroebuck committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    e578813 View commit details
    Browse the repository at this point in the history

  3. test(cli/config.spec.js): Update unit test

    @plroebuck
    plroebuck committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    5dcb8e3 View commit details
    Browse the repository at this point in the history

  4. test(cli/config.spec.js): Changed test title

    @plroebuck
    plroebuck committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    e6a61d1 View commit details
    Browse the repository at this point in the history

  5. fix(cli/config.js): Forgot to commit fix for parsing JSONC

    @plroebuck
    plroebuck committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    8bc0df6 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2019

  1. test(integration/config.spec.js): Add tests for configuring with a pa… 

    …ckage

As I used symlinks, some tests will likely fail on Windows...
    @plroebuck
    plroebuck committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    e344846 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2019

  1. test(integration/config.spec.js): Debug why this doesn't work in CI

    @plroebuck
    plroebuck committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    a3b0489 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. test(fixtures/config/mocha-config): Add fixture for Mocha configurati… 

    …on package

That moment when you realize the tests are failing b/c you forgot to commit the fixture...
    @plroebuck
    plroebuck committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    00450dd View commit details
    Browse the repository at this point in the history

  2. test(integration/config.spec.js): Remove debug and code cleanup 

    'Nuff said...
    @plroebuck
    plroebuck committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    0af6421 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2019

  1. refactor(mocha-config/package.json): Update for later

    @plroebuck
    plroebuck committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    24795ee View commit details
    Browse the repository at this point in the history

  2. test(integration/config.spec.js): Updated integration test

    @plroebuck
    plroebuck committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    55ce117 View commit details
    Browse the repository at this point in the history

  3. test(cli/config.spec.js): Updated CLI test 

    Reverted back to use JSON parser by default.
    @plroebuck
    plroebuck committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    9d46628 View commit details
    Browse the repository at this point in the history

  4. refactor(cli/config.js): Updates per PR review 

    Reverted `loadConfig` to default to JSON parser. Changed `parsers.js` to fallback to module-relative
loading, removing the package loader.
    @plroebuck
    plroebuck committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    7251c18 View commit details
    Browse the repository at this point in the history

  5. build(package.json): Revert addition of "validate-npm-package-name" p… 

    …ackage
    @plroebuck
    plroebuck committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    b51af9d View commit details
    Browse the repository at this point in the history

  6. Revert "build(package.json): Add "validate-npm-package-name" package"

    @plroebuck
    plroebuck committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    4853993 View commit details
    Browse the repository at this point in the history