Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): release 11.0.0 prerelease #5241

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 30, 2024

🤖 I have created a release beep boop

11.0.0 (2024-11-11)

⚠ BREAKING CHANGES

  • adapt new engine range for Mocha 11 (#5216)

🌟 Features

🩹 Fixes

📚 Documentation


This PR was generated with Release Please. See documentation.

@github-actions github-actions bot force-pushed the release-please--branches--main--components--mocha branch from 669773f to 91996c1 Compare November 6, 2024 18:08
@github-actions github-actions bot changed the title chore(main): release 10.9.0 chore(main): release 11.0.0 Nov 11, 2024
@github-actions github-actions bot force-pushed the release-please--branches--main--components--mocha branch from 91996c1 to 95b6b01 Compare November 11, 2024 15:46
@JoshuaKGoldberg JoshuaKGoldberg added this to the v11.0.0 milestone Nov 11, 2024
@JoshuaKGoldberg
Copy link
Member

https://github.com/mochajs/mocha/pull/5216/files#diff-79e894bd12b1ec1a260f6afff87ddaa3e1579fbac8cb64e8fac8cc88e8a6197eR6 should make this publish as a prerelease, not stable. But in case it publishes as stable after all I'll unpublish from npm.

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore(main): release 11.0.0 chore(main): release 11.0.0 prerelease Nov 11, 2024
Copy link
Contributor Author

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@JoshuaKGoldberg JoshuaKGoldberg merged commit d3b2c38 into main Nov 11, 2024
5 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the release-please--branches--main--components--mocha branch November 11, 2024 17:55
Copy link
Contributor Author

🤖 Created releases:

@voxpelli
Copy link
Member

Huh, wasn’t the intent to do a 11.0.0-beta or something first? 🤔

@JoshuaKGoldberg
Copy link
Member

That's what I would have liked more. I suppose we'll need to reconfigure release-please?

@voxpelli
Copy link
Member

It was what I intended it to do, but it’s hard to try the config before the PR is created and now that it’s merged it doesn’t matter much, we can only add on top of 11.0.0 – we could maybe reconfigure it to be 11.0.1-beta or such

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants