Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fix unwinding of classical elements #3800

Merged
merged 7 commits into from
Nov 18, 2023
Merged

Do not fix unwinding of classical elements #3800

merged 7 commits into from
Nov 18, 2023

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Nov 9, 2023 •
edited
Loading

Do not fix anything, we believe that it's just a singularity. Add a new ToMathematica utility.

eggrobin
eggrobin requested changes Nov 18, 2023
View reviewed changes
Copy link
Member

@eggrobin eggrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failures seem to say that this does not put the elements in the ranges we expect.

@pleroy
Copy link
Member Author

pleroy commented Nov 18, 2023

The test failures seem to say that this does not put the elements in the ranges we expect.

So these tests are actually useful? Fixed.

@pleroy pleroy changed the title Fix unwinding of classical elements Do not fix unwinding of classical elements Nov 18, 2023
@eggrobin eggrobin added the LGTM label Nov 18, 2023
@pleroy pleroy merged commit b9a621c into mockingbirdnest:master Nov 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eggrobin eggrobin eggrobin approved these changes

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pleroy @eggrobin