Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid cloning kani submodules and fix enable-propproof flag #24

Merged
merged 5 commits into from
Feb 15, 2023

Conversation

zhassan-aws
Copy link
Contributor

@zhassan-aws zhassan-aws commented Feb 14, 2023

Description of changes:

As part of installing PropProof, the GitHub action currently clones the Kani repo (the proptest branch) and initializes its submodules recursively. This unnecessarily brings in submodules used for development, e.g. s2n-quic, nomicon, firecracker, etc. This PR removes the --recursive option to avoid bringing in those submodules.

This PR also fixes the enable-propproof input, which was always being evaluated to true, thus executing the PropProof step regardless of the input value.

Resolved issues:

Resolves #25

Related RFC:

Call-outs:

Testing:

  • How is this change tested? Current tests

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

action.yml Outdated Show resolved Hide resolved
@zhassan-aws
Copy link
Contributor Author

I'm actually now confused why the PropProof step runs in the first place in s2n-quic's CI given that it is guarded by the enable-propproof input, which is not used in s2n-quic's workflow. This is a bit orthogonal, but any ideas?

@zhassan-aws
Copy link
Contributor Author

Filed this as #25

@zhassan-aws zhassan-aws changed the title Avoid cloning kani submodules Avoid cloning kani submodules and fix enable-propproof flag Feb 15, 2023
@zhassan-aws
Copy link
Contributor Author

I added another commit (a6fd203) that fixes #25 as well.

Copy link
Contributor

@adpaco-aws adpaco-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhassan-aws for catching and fixing #25 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The action's PropProof step runs regardless of enable-propproof
3 participants